Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 7582014: Remove metafile casts. (Closed)

Created:
9 years, 4 months ago by vandebo (ex-Chrome)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove metafile casts. Change PrintWebViewHelper::PrintPreviewContext to have a PreviewMetafile, removing the need to cast it. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95911

Patch Set 1 #

Patch Set 2 : Add missing header #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M chrome/renderer/print_web_view_helper.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/print_web_view_helper_linux.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/print_web_view_helper_mac.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/print_web_view_helper_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vandebo (ex-Chrome)
9 years, 4 months ago (2011-08-05 18:51:35 UTC) #1
Lei Zhang
LGTM
9 years, 4 months ago (2011-08-05 19:11:31 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-08 23:53:00 UTC) #3
Change committed as 95911

Powered by Google App Engine
This is Rietveld 408576698