[cros] Various WebUI OOBE issues

[cros] Various WebUI OOBE issues
- removed i-beam cursor for labels
- lowercases labels tet
- changed buttons height to 29 pixels
- 1px border around EULA texts
- checkbox label font smaller
- Learn More link color changed

BUG=chromium-os:17335
TEST=Go through WebUI OOBE manually and verify the changes in description.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95799

[whywhat, 2011-08-05 18:40:08]

On Aug 5, 2011 8:00 PM, <avayvod@chromium.org> wrote:
> Reviewers: ,
>
> Description:
> [cros] Various WebUI OOBE issues
> - removed i-beam cursor for labels
> - lowercases labels tet
> - changed buttons height to 29 pixels
> - 1px border around EULA texts
> - checkbox label font smaller
> - Learn More link color changed
>
> BUG=chromium-os:17335
> TEST=Go through WebUI OOBE manually and verify the changes in description.
>
>
> Please review this at http://codereview.chromium.org/7582008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M chrome/browser/resources/chromeos/login/oobe.css
>
>
> Index: chrome/browser/resources/chromeos/login/oobe.css
> diff --git a/chrome/browser/resources/chromeos/login/oobe.css
> b/chrome/browser/resources/chromeos/login/oobe.css
> index
>
e8d6682998e28f325055dda18c374f48022760d8..eff7b50d3ffeab9137956e0f217255139d392b00

> 100644
> --- a/chrome/browser/resources/chromeos/login/oobe.css
> +++ b/chrome/browser/resources/chromeos/login/oobe.css
> @@ -36,6 +36,10 @@ body {
> text-decoration: none;
> }
>
> +#eula #stats-help-link {
> + color: #316ac5;
> +}
> +
> hr.topshadow {
> -webkit-mask: -webkit-linear-gradient(left, rgba(0,0,0,0),
> black 50%, rgba(0,0,0,0));
> @@ -70,6 +74,13 @@ hr.bottomshadow {
> padding-left: 54px;
> }
>
> +#header span,
> +#logging span,
> +#user-image-screen-curtain p,
> +.label {
> + cursor: default;
> +}
> +
> #header-sections {
> position: relative;
> }
> @@ -83,6 +94,7 @@ hr.bottomshadow {
> .header-section {
> -webkit-transition: left .2s, opacity .2s ease-in-out;
> position: absolute;
> + text-transform: lowercase;
> width: 20em;
> }
>
> @@ -94,6 +106,7 @@ hr.bottomshadow {
> left: -20px;
> }
>
> +
> .step {
> -webkit-transition: left .2s, opacity .2s, visibility .2s ease-in-out;
> left: 0;
> @@ -166,6 +179,7 @@ hr.bottomshadow {
>
> #logging {
> clear: both;
> + font-size: small;
> margin-top: 20px;
> }
>
> @@ -197,6 +211,7 @@ hr.bottomshadow {
>
> #footer button {
> display: none;
> + height: 29px;
> }
>
> #oobe.connect #continue-button,
> @@ -267,6 +282,11 @@ button {
> width: 310px;
> }
>
> +#cros-eula,
> +#oem-eula {
> + border: 1px solid #d9d9d9;
> +}
> +
> #eulas.one-column #cros-eula {
> width: 100%;
> }
>
>

[xiyuan, 2011-08-05 18:46:58]

LGTM

http://codereview.chromium.org/7582008/diff/2001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/7582008/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:40: color: #316ac5;
do we still need "#eula a" above?

http://codereview.chromium.org/7582008/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:81: cursor: default;
Can we put this into body instead of specifying them separately?

[whywhat, 2011-08-08 06:22:53]

http://codereview.chromium.org/7582008/diff/2001/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/7582008/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:40: color: #316ac5;
On 2011/08/05 18:46:58, xiyuan wrote:
> do we still need "#eula a" above?

I guess we need it if it affects links in EULA iframes or Learn more popup

http://codereview.chromium.org/7582008/diff/2001/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe.css:81: cursor: default;
On 2011/08/05 18:46:58, xiyuan wrote:
> Can we put this into body instead of specifying them separately?

Won't it break the right cursor for links and other elements?