Issue 7582007: Fixup bad include and usage of BASE_API, which should be BASE_EXPORT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7582007: Fixup bad include and usage of BASE_API, which should be BASE_EXPORT. (Closed)

Created:
9 years, 4 months ago by darin (slow to review)

Modified:
9 years, 4 months ago

Reviewers:
Lei Zhang, agl, rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixup bad include and usage of BASE_API, which should be BASE_EXPORT. TBR=rvargas@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95619

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	net/proxy/proxy_config_service_linux.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	sandbox/linux/suid/process_util.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

I don't really understand how the sandbox part works, but it looks wrong to have ...

9 years, 4 months ago (2011-08-05 18:22:53 UTC) #3

darin (slow to review)

9 years, 4 months ago (2011-08-05 18:25:23 UTC) #4

Right, I have exactly the same concern, and I want to investigate that.

On Fri, Aug 5, 2011 at 11:22 AM, <rvargas@chromium.org> wrote:

> I don't really understand how the sandbox part works, but it looks wrong to
> have
> a BASE_EXPORT outside of base (base doesn't seem to depend on the sandbox
> code).
>
> But being that this CL is just fixing a BASE_API LGTM.
>
>
>
http://codereview.chromium.**org/7582007/<http://codereview.chromium.org/7582...
>

Expand Messages | Collapse Messages