Add check to help prevent test-only function usage in production code.

PRESUBMIT.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 20 matching lines @@
 
   if len(files):
     return [ output_api.PresubmitError(
         'Objective-C interfaces or categories are forbidden in libbase. ' +
         'See http://groups.google.com/a/chromium.org/group/chromium-dev/' +
         'browse_thread/thread/efb28c10435987fd',
         files) ]
   return []
 
 
+def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
+  """Attempts to prevent use of functions intended only for testing in
+  non-testing code. For now this is just a best-effort implementation
+  that ignores header files and may have some false positives. A
+  better implementation would probably need a proper C++ parser.
+  """
+  # We only scan .cc files and the like, as the declaration of
+  # for-testing functions in header files are hard to distinguish from
+  # calls to such functions without a proper C++ parser.
+  source_extensions = r'\.(cc|cpp|cxx|mm)$'
+  file_inclusion_pattern = input_api.re.compile(source_extensions)
+  file_exclusion_pattern = input_api.re.compile(
+    r'(_test_support|_(unit|browser|ui|perf)test)%s' % source_extensions)
+
+  base_function_pattern = r'ForTest(ing)?|for_test(ing)?'
+  inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern)
+  exclusion_pattern = input_api.re.compile(
+    r'::[A-Za-z0-9_]+(%s)|(%s)[^;]+\{' % (
+      base_function_pattern, base_function_pattern))
+
+  problems = []
+  for f in input_api.AffectedSourceFiles(input_api.FilterSourceFile):
+    local_path = f.LocalPath()
+    if (file_inclusion_pattern.search(local_path) and
+        not file_exclusion_pattern.search(local_path)):

[M-A Ruel, 2011/08/05 18:27:41]

It should use a source filter instead and you need to use _EXCLUDED_PATHS.

[Jói, 2011/08/08 23:11:00]

Done.

+      lines = input_api.ReadFile(f).split('\n')

[M-A Ruel, 2011/08/05 18:27:41]

splitlines()

[Jói, 2011/08/08 23:11:00]

Done.

+      line_number = 0
+      for line in lines:
+        if (inclusion_pattern.search(line) and
+            not exclusion_pattern.search(line)):
+          problems.append(
+            '%s:%d\n    %s' % (local_path, line_number, line.strip()))
+        line_number += 1
+
+  if problems:
+    return [output_api.PresubmitPromptWarning(
+        'You might be calling functions intended only for testing from\n' +

[M-A Ruel, 2011/08/05 18:27:41]

no need for +

[Jói, 2011/08/08 23:11:00]

Done.

+        'production code. Please verify that the following usages are OK,\n' +
+        'and email joi@chromium.org if this presubmit check needs to be\n' +
+        'improved because of frequent false positives:',
+        problems)]
+  else:
+    return []
+
+
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
   results.extend(input_api.canned_checks.PanProjectChecks(
       input_api, output_api, excluded_paths=_EXCLUDED_PATHS))
   results.extend(_CheckNoInterfacesInBase(input_api, output_api))
   results.extend(_CheckAuthorizedAuthor(input_api, output_api))
+  results.extend(
+    _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
   return results
 
 
 def _CheckSubversionConfig(input_api, output_api):
   """Verifies the subversion config file is correctly setup.
 
   Checks that autoprops are enabled, returns an error otherwise.
   """
   join = input_api.os_path.join
   if input_api.platform == 'win32':
@@ skipping 88 matching lines @@
   results.extend(input_api.canned_checks.CheckChangeHasBugField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
   results.extend(_CheckSubversionConfig(input_api, output_api))
   return results
 
 
 def GetPreferredTrySlaves():
   return ['win', 'linux', 'mac']