Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 758002: Make views depend on Xext (Closed)

Created:
10 years, 9 months ago by DaveMoore
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Add a gyp target for Xext to linux/system so that Views can depend on it. A recent change added a code dependency within Views on linux on this library. Chrome was linking with it but other Views apps (candidate_window) weren't Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41097

Patch Set 1 #

Patch Set 2 : Had merge collisions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/linux/system.gyp View 1 chunk +20 lines, -0 lines 0 comments Download
M views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaveMoore
I added a dependency on Xext for Views on linux (to support clicks passing through ...
10 years, 9 months ago (2010-03-09 22:58:07 UTC) #1
Evan Martin
Can you make your commit description meaningful? (Sorry to pick on you, but I feel ...
10 years, 9 months ago (2010-03-09 23:02:05 UTC) #2
DaveMoore
10 years, 9 months ago (2010-03-09 23:08:15 UTC) #3
I'll do that, but the reason for the change is that the xext library dependency
is in Chrome, but the code dependency is in views. candidate_window needs to
pick up the change as well.

On 2010/03/09 23:02:05, Evan Martin wrote:
> Can you make your commit description meaningful?  (Sorry to pick on you, but I
> feel like 80% of the ChromeOS commits never describe why they're making the
> change they're making.)  Like say perhaps which function or which change made
> this necessary, etc.
> 
> I guess we already depend on libXext, so I'm a little surprised this is
needed,
> but it looks good otherwise.
> 
> $ ldd /opt/google/chrome/chrome | grep Xext
> 	libXext.so.6 => /usr/lib/libXext.so.6 (0x00007fc0aedc9000)

Powered by Google App Engine
This is Rietveld 408576698