Disable Instant field trial when suggest has been disabled.

Disable Instant field trial when suggest has been disabled.

When suggest has been disabled, omnibox text is not sent to the default search
engine. Instant's field trial should also be disabled in such a case, to avoid
sending the omnibox text due to Instant.

Note that if the Instant experiment has already been enabled, and *then* the
user disables suggest, this won't disable the experiment immediately (since we
don't listen for changes to prefs::kSuggestEnabled). Instead, it will be
disabled at the next opportunity (some Instant pref changing, browser restart,
etc). I think this is acceptable since, if the user is fiddling with
preferences after Instant has been enabled, they can already click the Instant
checkbox to turn it off.

BUG=91730
TEST=Disable suggest. Verify that the Instant field trial doesn't get enabled.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95723

[sreeram, 2011-08-05 15:00:49]

Please review.

[sreeram, 2011-08-05 18:57:51]

@sky seems be offline. Could somebody else please take a look?

[dominich, 2011-08-05 19:11:37]

LGTM

[brettw, 2011-08-05 23:21:53]

On 2011/08/05 18:57:51, sreeram wrote:
> @sky seems be offline. Could somebody else please take a look?

Please don't spam multiple people when you're not sure who to pick, since it can
create confusion and adds to people's inboxes. If you're not sure who's
available check on IM or IRC.

[sreeram, 2011-08-05 23:41:44]

On Fri, Aug 5, 2011 at 16:21,  <brettw@chromium.org> wrote:
> Please don't spam multiple people when you're not sure who to pick, since it
> can create confusion and adds to people's inboxes. If you're not sure who's
> available check on IM or IRC.

I did ask on IRC, but nobody responded :( The chrome privacy team
wants this change to go through soon, hence the scattershot addition
of reviewers. I thought this was better than pinging each individual
reviewer through IM (which seems more intrusive and interruptive).

Anyway, thanks @dominich for the review and LGTM.

[commit-bot: I haz the power, 2011-08-06 01:24:47]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 95672, job name
was 7578014-1 (previous was lost) (previous was lost) (retry) (previous was
lost).

[commit-bot: I haz the power, 2011-08-06 03:20:17]

Change committed as 95723

[sky, 2011-08-08 16:06:11]

LGTM