Issue 7578009: Don't examine jingleNode unless it's non-null.

Issue 7578009: Don't examine jingleNode unless it's non-null. (Closed)

Created:
9 years, 4 months ago by Jamie

Modified:
9 years, 4 months ago

Reviewers:
Sergey Ulanov, commit-bot: I haz the power

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't examine jingleNode unless it's non-null. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95526

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	remoting/webapp/me2mom/client_session.js	View		1 chunk	+6 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

This CL gets rid of the "Exception when invoking JS sendiq callback" errors that pop ...

9 years, 4 months ago (2011-08-04 20:40:18 UTC) #1

Sergey Ulanov

LGTM http://codereview.chromium.org/7578009/diff/1/remoting/webapp/me2mom/client_session.js File remoting/webapp/me2mom/client_session.js (right): http://codereview.chromium.org/7578009/diff/1/remoting/webapp/me2mom/client_session.js#newcode208 remoting/webapp/me2mom/client_session.js:208: 'payload_xml': serializer.serializeToString(jingleNode), Does this serialize null to an ...

9 years, 4 months ago (2011-08-04 20:46:18 UTC) #2

Jamie

http://codereview.chromium.org/7578009/diff/1/remoting/webapp/me2mom/client_session.js File remoting/webapp/me2mom/client_session.js (right): http://codereview.chromium.org/7578009/diff/1/remoting/webapp/me2mom/client_session.js#newcode208 remoting/webapp/me2mom/client_session.js:208: 'payload_xml': serializer.serializeToString(jingleNode), On 2011/08/04 20:46:19, sergeyu wrote: > Does ...

9 years, 4 months ago (2011-08-04 20:46:57 UTC) #3

Change committed as 95526

Expand Messages | Collapse Messages