Issue 7578005: Get correct driver version on ES backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7578005: Get correct driver version on ES backend. (Closed)

Created:
9 years, 4 months ago by Zhenyao Mo

Modified:
9 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get correct driver version on ES backend. GL_VERSION format differs in GL and GLES: the latter starts with "OpenGL ES". BUG=none TEST=driver vendor/version shows correct information in about:gpu for ES backend. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95453

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/gpu/gpu_info_collector_linux.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM -- I suspect we may need to test on more drivers though.

9 years, 4 months ago (2011-08-04 18:33:22 UTC) #2

Zhenyao Mo

9 years, 4 months ago (2011-08-04 18:35:37 UTC) #3

On 2011/08/04 18:33:22, kbr wrote:
> LGTM -- I suspect we may need to test on more drivers though.

Right.  This so far works for NVIDIA/Mesa on linux.  ATI is another story (which
we have a different way of collecting driver version). Haven't got any chance to
look at other driver implementations.

Expand Messages | Collapse Messages