Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: webkit/plugins/ppapi/npapi_glue.cc

Issue 7578001: Unify var tracking between webkit and the proxy. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_var_deprecated.cc ('k') | webkit/plugins/ppapi/npobject_var.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/npapi_glue.cc
===================================================================
--- webkit/plugins/ppapi/npapi_glue.cc (revision 96002)
+++ webkit/plugins/ppapi/npapi_glue.cc (working copy)
@@ -159,7 +159,7 @@
// been lost.
DCHECK(checked_exception_);
- NPObjectVar::PluginReleasePPVar(exception_);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(exception_);
}
// Call this with the return value of the PPAPI function. It will convert
@@ -184,7 +184,7 @@
// No matter what happened, we need to release the reference to the
// value passed in. On success, a reference to this value will be in
// the np_result_.
- ::ppapi::Var::PluginReleasePPVar(result);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(result);
return success_;
}
@@ -237,8 +237,9 @@
}
PPVarArrayFromNPVariantArray::~PPVarArrayFromNPVariantArray() {
+ ::ppapi::VarTracker* var_tracker = ResourceTracker::Get()->GetVarTracker();
for (size_t i = 0; i < size_; i++)
- ::ppapi::Var::PluginReleasePPVar(array_[i]);
+ var_tracker->ReleaseVar(array_[i]);
}
// PPVarFromNPObject -----------------------------------------------------------
@@ -248,7 +249,7 @@
}
PPVarFromNPObject::~PPVarFromNPObject() {
- ::ppapi::Var::PluginReleasePPVar(var_);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(var_);
}
// NPObjectAccessorWithIdentifier ----------------------------------------------
@@ -268,7 +269,7 @@
}
NPObjectAccessorWithIdentifier::~NPObjectAccessorWithIdentifier() {
- ::ppapi::Var::PluginReleasePPVar(identifier_);
+ ResourceTracker::Get()->GetVarTracker()->ReleaseVar(identifier_);
}
// TryCatch --------------------------------------------------------------------
« no previous file with comments | « ppapi/tests/test_var_deprecated.cc ('k') | webkit/plugins/ppapi/npobject_var.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698