Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: ppapi/proxy/serialized_var_unittest.cc

Issue 7578001: Unify var tracking between webkit and the proxy. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/resource_creation_proxy.cc ('k') | ppapi/shared_impl/id_assignment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/serialized_var_unittest.cc
===================================================================
--- ppapi/proxy/serialized_var_unittest.cc (revision 96002)
+++ ppapi/proxy/serialized_var_unittest.cc (working copy)
@@ -99,9 +99,9 @@
// release it, we should still be tracking the object since the
// ReceiveInputs keep the "track_with_no_reference_count" alive until
// they're destroyed.
- var_tracker().AddRef(plugin_object);
+ var_tracker().AddRefVar(plugin_object);
EXPECT_EQ(1, var_tracker().GetRefCountForObject(plugin_object));
- var_tracker().Release(plugin_object);
+ var_tracker().ReleaseVar(plugin_object);
EXPECT_EQ(0, var_tracker().GetRefCountForObject(plugin_object));
EXPECT_EQ(2u, sink().message_count());
}
@@ -143,13 +143,13 @@
EXPECT_EQ(1u, sink().message_count());
// Manually release one refcount, it shouldn't have sent any more messages.
- var_tracker().Release(plugin_object);
+ var_tracker().ReleaseVar(plugin_object);
EXPECT_EQ(1, var_tracker().GetRefCountForObject(plugin_object));
EXPECT_EQ(1u, sink().message_count());
// Manually release the last refcount, it should have freed it and sent a
// release message to the browser.
- var_tracker().Release(plugin_object);
+ var_tracker().ReleaseVar(plugin_object);
EXPECT_EQ(-1, var_tracker().GetRefCountForObject(plugin_object));
EXPECT_EQ(2u, sink().message_count());
}
« no previous file with comments | « ppapi/proxy/resource_creation_proxy.cc ('k') | ppapi/shared_impl/id_assignment.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698