Issue 7577001: Print Preview: Fix crash in PrepareFrameAndViewForPrint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7577001: Print Preview: Fix crash in PrepareFrameAndViewForPrint. (Closed)

Created:
9 years, 4 months ago by Lei Zhang

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, kmadhusu

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Print Preview: Fix crash in PrepareFrameAndViewForPrint. BUG=90887 TEST=Find a way to trigger a print preview generation failure, then reload the print preview tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95471

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/renderer/print_web_view_helper.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/renderer/print_web_view_helper.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

If print preview ever fail, we currently go into the UNINITIALIZED state. If we reload ...

9 years, 4 months ago (2011-08-04 03:04:43 UTC) #1

Change committed as 95471