Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 7576026: PPAPI: header comments on when PPP_Instance::DidDestroy and PPP_ShutdownModule (Closed)

Created:
9 years, 4 months ago by polina
Modified:
9 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

PPAPI: header comments on when PPP_Instance::DidDestroy and PPP_ShutdownModule are called on trusted and untrusted implementations. BUG=91758 TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95835

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -27 lines) Patch
M ppapi/api/ppp.idl View 1 1 chunk +6 lines, -2 lines 0 comments Download
M ppapi/api/ppp_instance.idl View 1 1 chunk +9 lines, -8 lines 0 comments Download
M ppapi/c/ppp.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M ppapi/c/ppp_instance.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M ppapi/cpp/instance.h View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
polina
9 years, 4 months ago (2011-08-05 01:12:31 UTC) #1
brettw
Will native client developers know that "untrusted" is them? I always have to think briefly ...
9 years, 4 months ago (2011-08-05 23:17:07 UTC) #2
brettw
9 years, 4 months ago (2011-08-05 23:17:10 UTC) #3
dmichael (off chromium)
I agree with brettw. I think wording like 'native client' instead of 'untrusted' may make ...
9 years, 4 months ago (2011-08-06 02:14:17 UTC) #4
polina
On 2011/08/06 02:14:17, dmichael wrote: > I agree with brettw. I think wording like 'native ...
9 years, 4 months ago (2011-08-08 14:02:46 UTC) #5
brettw
LGTM
9 years, 4 months ago (2011-08-08 14:58:47 UTC) #6
polina
9 years, 4 months ago (2011-08-08 17:46:27 UTC) #7
On 2011/08/08 14:58:47, brettw wrote:
> LGTM

Committed revision 95835.

Powered by Google App Engine
This is Rietveld 408576698