Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5689)

Unified Diff: chrome/browser/ui/webui/web_ui_test_handler.h

Issue 7576024: Provide ability for WebUIBrowserTests to run asynchronous tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added failure and test when asyncTestDone() is called for non-async tests. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/web_ui_test_handler.h
diff --git a/chrome/browser/ui/webui/web_ui_test_handler.h b/chrome/browser/ui/webui/web_ui_test_handler.h
index 4c2ea3855b7ace2f4b05ca71bd24885379677902..dfb0ace32fbf5005e7a18ad58846e41f81e1a2dd 100644
--- a/chrome/browser/ui/webui/web_ui_test_handler.h
+++ b/chrome/browser/ui/webui/web_ui_test_handler.h
@@ -10,10 +10,18 @@
#include "content/browser/webui/web_ui.h"
#include "content/common/notification_observer.h"
+namespace base {
+
+class ListValue;
+
+} // namespace base
+
// This class registers test framework specific handlers on WebUI objects.
class WebUITestHandler : public WebUIMessageHandler,
public NotificationObserver {
public:
+ WebUITestHandler();
+
// Sends a message through |preload_host| with the |js_text| to preload at the
// appropriate time before the onload call is made.
void PreloadJavaScript(const string16& js_text,
@@ -23,27 +31,42 @@ class WebUITestHandler : public WebUIMessageHandler,
void RunJavaScript(const string16& js_text);
// Runs |js_text| in this object's WebUI frame. Waits for result, logging an
- // error message on failure. Returns test pass/fail.
- bool RunJavaScriptTestWithResult(const string16& js_text);
+ // error message on failure. Returns test pass/fail. When |is_async| is true,
+ // waits for asyncTestDone() to be called from javascript code.
+ bool RunJavaScriptTestWithResult(const string16& js_text, bool is_async);
private:
// WebUIMessageHandler overrides.
// Add test handlers to the current WebUI object.
- virtual void RegisterMessages() OVERRIDE {}
+ virtual void RegisterMessages() OVERRIDE;
+
+ // Receives asyncTestResult messages.
+ void HandleAsyncTestResult(const base::ListValue* test_result);
+
+ // Populates |success| from |test_result|, logging messages to ERROR, upon
+ // failure.
+ void HandleTestResult(const base::ListValue* test_result, bool* success);
// From NotificationObserver.
virtual void Observe(int type,
const NotificationSource& source,
const NotificationDetails& details) OVERRIDE;
- // Runs a message loop until test finishes. Returns the result of the test.
- bool WaitForResult();
+ // Runs a message loop until test finishes. Returns the result of the
+ // test. When |is_async| is true, waits for asyncTestDone() to be called from
+ // javascript code.
+ bool WaitForResult(bool is_async);
// Pass fail result of current tests.
bool test_succeeded_;
// Waiting for a test to finish.
bool is_waiting_;
+
+ // Received async completion pass/fail;
+ bool test_done_async_;
+
+ DISALLOW_COPY_AND_ASSIGN(WebUITestHandler);
};
#endif // CHROME_BROWSER_UI_WEBUI_WEB_UI_TEST_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698