Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 7576020: Verify the existence of source files in VS2008. Missing source files are now treated as errors. (Closed)

Created:
9 years, 4 months ago by jeanluc1
Modified:
9 years, 4 months ago
Reviewers:
bradnelson, bradn
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Verify the existence of source files in VS2008. Missing source files are now treated as errors. BUG=207 Committed: http://code.google.com/p/gyp/source/detail?r=986

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M pylib/gyp/generator/msvs.py View 1 5 chunks +29 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bradn
LGTM
9 years, 4 months ago (2011-08-04 23:07:29 UTC) #1
jeanluc1
9 years, 4 months ago (2011-08-04 23:31:59 UTC) #2
Brad, is printing "Error:" at the start of a line sufficient for the build
system to choke?

Powered by Google App Engine
This is Rietveld 408576698