Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: webkit/plugins/ppapi/ppb_graphics_3d_impl.cc

Issue 7576012: Removed config management from Graphics3D API. It will be better handled in the EGL helper library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppb_graphics_3d_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_graphics_3d_impl.cc (revision 95134)
+++ webkit/plugins/ppapi/ppb_graphics_3d_impl.cc (working copy)
@@ -62,26 +62,24 @@
// static
PP_Resource PPB_Graphics3D_Impl::Create(PluginInstance* instance,
- PP_Config3D_Dev config,
PP_Resource share_context,
const int32_t* attrib_list) {
scoped_refptr<PPB_Graphics3D_Impl> graphics_3d(
new PPB_Graphics3D_Impl(instance));
- if (!graphics_3d->Init(config, share_context, attrib_list))
+ if (!graphics_3d->Init(share_context, attrib_list))
return 0;
return graphics_3d->GetReference();
}
PP_Resource PPB_Graphics3D_Impl::CreateRaw(PluginInstance* instance,
- PP_Config3D_Dev config,
PP_Resource share_context,
const int32_t* attrib_list) {
scoped_refptr<PPB_Graphics3D_Impl> graphics_3d(
new PPB_Graphics3D_Impl(instance));
- if (!graphics_3d->InitRaw(config, share_context, attrib_list))
+ if (!graphics_3d->InitRaw(share_context, attrib_list))
return 0;
return graphics_3d->GetReference();
@@ -172,10 +170,9 @@
return PP_OK_COMPLETIONPENDING;
}
-bool PPB_Graphics3D_Impl::Init(PP_Config3D_Dev config,
- PP_Resource share_context,
+bool PPB_Graphics3D_Impl::Init(PP_Resource share_context,
const int32_t* attrib_list) {
- if (!InitRaw(config, share_context, attrib_list))
+ if (!InitRaw(share_context, attrib_list))
return false;
gpu::CommandBuffer* command_buffer = GetCommandBuffer();
@@ -185,8 +182,7 @@
return CreateGLES2Impl(kCommandBufferSize, kTransferBufferSize);
}
-bool PPB_Graphics3D_Impl::InitRaw(PP_Config3D_Dev config,
- PP_Resource share_context,
+bool PPB_Graphics3D_Impl::InitRaw(PP_Resource share_context,
const int32_t* attrib_list) {
// TODO(alokp): Support shared context.
DCHECK_EQ(0, share_context);

Powered by Google App Engine
This is Rietveld 408576698