Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: webkit/plugins/ppapi/ppb_context_3d_impl.cc

Issue 7576012: Removed config management from Graphics3D API. It will be better handled in the EGL helper library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppb_context_3d_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_context_3d_impl.cc (revision 95134)
+++ webkit/plugins/ppapi/ppb_context_3d_impl.cc (working copy)
@@ -152,13 +152,13 @@
// TODO(alokp): Support separate draw-read surfaces.
DCHECK_EQ(new_draw, new_read);
if (new_draw != new_read)
- return PP_GRAPHICS3DERROR_BAD_MATCH;
+ return PP_ERROR_NOTSUPPORTED;
if (new_draw == draw_surface_)
return PP_OK;
if (new_draw && new_draw->context())
- return PP_GRAPHICS3DERROR_BAD_ACCESS; // Already bound.
+ return PP_ERROR_BADARGUMENT; // Already bound.
if (draw_surface_)
draw_surface_->BindToContext(NULL);
@@ -302,7 +302,7 @@
PP_GRAPHICS3DATTRIB_SAMPLE_BUFFERS, 0,
PP_GRAPHICS3DATTRIB_HEIGHT, 1,
PP_GRAPHICS3DATTRIB_WIDTH, 1,
- PP_GRAPHICS3DATTRIBVALUE_NONE,
+ PP_GRAPHICS3DATTRIB_NONE,
};
if (!platform_context_->Init(kAttribs)) {
Destroy();

Powered by Google App Engine
This is Rietveld 408576698