Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ppapi/thunk/ppb_graphics_3d_thunk.cc

Issue 7576012: Removed config management from Graphics3D API. It will be better handled in the EGL helper library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/thunk/ppb_graphics_3d_thunk.cc
===================================================================
--- ppapi/thunk/ppb_graphics_3d_thunk.cc (revision 95134)
+++ ppapi/thunk/ppb_graphics_3d_thunk.cc (working copy)
@@ -17,32 +17,19 @@
typedef EnterResource<PPB_Graphics3D_API> EnterGraphics3D;
-int32_t GetConfigs(PP_Config3D_Dev* configs,
- int32_t config_size,
- int32_t* num_config) {
- // TODO(alokp): Implement me.
- return PP_ERROR_FAILED;
-}
-
-int32_t GetConfigAttribs(PP_Config3D_Dev config, int32_t* attrib_list) {
- // TODO(alokp): Implement me.
- return PP_ERROR_FAILED;
-}
-
PP_Var GetString(int32_t name) {
// TODO(alokp): Implement me.
return PP_MakeUndefined();
}
PP_Resource Create(PP_Instance instance,
- PP_Config3D_Dev config,
PP_Resource share_context,
const int32_t* attrib_list) {
EnterFunction<ResourceCreationAPI> enter(instance, true);
if (enter.failed())
return 0;
- return enter.functions()->CreateGraphics3D(instance, config, share_context,
- attrib_list);
+ return enter.functions()->CreateGraphics3D(
+ instance, share_context, attrib_list);
}
PP_Bool IsGraphics3D(PP_Resource resource) {
@@ -80,8 +67,6 @@
}
const PPB_Graphics3D_Dev g_ppb_graphics_3d_thunk = {
- &GetConfigs,
- &GetConfigAttribs,
&GetString,
&Create,
&IsGraphics3D,

Powered by Google App Engine
This is Rietveld 408576698