Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 7575025: mac: Pin page info contents to top of bubble. (Closed)

Created:
9 years, 4 months ago by Nico
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Pin page info contents to top of bubble. BUG=none TEST=Click favicon. Page info bubble shouldn't jump around after 1s but look nice instead (mostly. Now the text at the bottom jumps now, but that looks way better than everything but the text jumping.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/page_info_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Pet peeve; happened to see this easy fix while doing lion-y stuff. Are you aware ...
9 years, 4 months ago (2011-08-04 23:12:07 UTC) #1
viettrungluu
LGTM
9 years, 4 months ago (2011-08-05 00:21:03 UTC) #2
Robert Sesek
On 2011/08/04 23:12:07, Nico wrote: > Pet peeve; happened to see this easy fix while ...
9 years, 4 months ago (2011-08-05 00:54:40 UTC) #3
commit-bot: I haz the power
9 years, 4 months ago (2011-08-05 04:00:12 UTC) #4
Change committed as 95564

Powered by Google App Engine
This is Rietveld 408576698