Issue 7575016: Don't use JingleThread in the client plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7575016: Don't use JingleThread in the client plugin. (Closed)

Created:
9 years, 4 months ago by Sergey Ulanov

Modified:
9 years, 4 months ago

Reviewers:
awong

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't use JingleThread in the client plugin. TEST=client works with seccomp sandbox. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95511

Patch Set 1 #

Patch Set 2 : update DEPS #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -23 lines)			Patch
M	remoting/client/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/client/chromoting_client.cc	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	remoting/client/client_context.h	View		3 chunks	+3 lines, -7 lines	0 comments	Download
M	remoting/client/client_context.cc	View		3 chunks	+6 lines, -13 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

awong

LGTM Yay! No more JingleThread! Is that whole thing deletable now?

9 years, 4 months ago (2011-08-04 20:07:05 UTC) #2

Sergey Ulanov

9 years, 4 months ago (2011-08-04 20:10:34 UTC) #3

On 2011/08/04 20:07:05, awong wrote:
> LGTM
> 
> Yay! No more JingleThread!
> 
> Is that whole thing deletable now?

Not yet, we still need it on the host side for IO. We'll need to implement our
own PacketSocketFactory that works with chromium sockets to get rid of it
completely.

Expand Messages | Collapse Messages