Issue 7575015: Add content-security-policy directive to chrome://history2 pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7575015: Add content-security-policy directive to chrome://history2 pages. (Closed)

Created:
9 years, 4 months ago by Tom Sepez

Modified:
9 years, 4 months ago

Reviewers:
abarth-chromium, Evan Stade

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, arv (Not doing code reviews), dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add content-security-policy directive to chrome://history2 pages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95495

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1147 lines, -1160 lines)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/history2.html	View		3 chunks	+9 lines, -1094 lines	0 comments	Download
A	chrome/browser/resources/history2.js	View	1	1 chunk	+1102 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/history2_ui.cc	View		3 chunks	+32 lines, -63 lines	0 comments	Download
M	chrome/test/functional/special_tabs.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/7575015/diff/1/chrome/browser/resources/history2.js File chrome/browser/resources/history2.js (right): http://codereview.chromium.org/7575015/diff/1/chrome/browser/resources/history2.js#newcode1094 chrome/browser/resources/history2.js:1094: $('history-section').onclick = function () { connect onclick handlers ...

9 years, 4 months ago (2011-08-04 18:06:58 UTC) #2

Tom Sepez

9 years, 4 months ago (2011-08-04 18:18:24 UTC) #3

http://codereview.chromium.org/7575015/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history2.js (right):

http://codereview.chromium.org/7575015/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history2.js:1094: $('history-section').onclick =
function () {
On 2011/08/04 18:06:58, Evan Stade wrote:
> connect onclick handlers in load()?

Sure.  Why not.  Done.

Expand Messages | Collapse Messages

Issue 7575015: Add content-security-policy directive to chrome://history2 pages. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages