bookmarks: Add more keyboard accelerators to bookmark bar context menu.

chrome/app/generated_resources.grd

 <?xml version="1.0" encoding="UTF-8"?>
 
 <!--
 This file contains definitions of resources that will be translated for each
 locale.  The variables is_win, is_macosx, is_linux, and is_posix are available
 for making strings OS specific.  Other platform defines such as use_titlecase
 are declared in build/common.gypi.
 -->
 
 <grit base_dir="." latest_public_release="0" current_release="1"
@@ skipping 6218 matching lines @@
         <message name="IDS_APP_MENU_COPY_URL" desc="In Title Case: The copy url menu in application windows">
           Copy URL
         </message>
         <message name="IDS_APP_MENU_NEW_WEB_PAGE" desc="In Title Case: The new webpage menu in application windows">
           Open Browser Window
         </message>
       </if>
 
       <!-- bookmark bar messages -->
       <if expr="not pp_ifdef('use_titlecase')">
         <message name="IDS_BOOMARK_BAR_ALWAYS_SHOW" desc="Menu item for having bookmark bar always visible">

[Peter Kasting, 2011/08/09 22:10:46]

Can we eliminate this and make code that uses it use IDS_SHOW_BOOKMARK_BAR
instead?  That will give this an accelerator as well ('A').

[tfarina, 2011/08/09 23:58:48]

When I replace IDS_BOOKMARK_BAR_ALWAYS_SHOW by IDS_SHOW_BOOKMARK_BAR I get a
weird context menu entries. I don't know why though.

           Always show bookmarks bar
         </message>
       </if>
       <if expr="pp_ifdef('use_titlecase')">
         <message name="IDS_BOOMARK_BAR_ALWAYS_SHOW" desc="In Title Case: Menu item for having bookmark bar always visible">
           Always Show Bookmarks Bar
         </message>
       </if>
       <message name="IDS_BOOMARK_BAR_OTHER_BOOKMARKED" desc="Title of button showing other bookmarks">
         Other bookmarks
       </message>
       <if expr="not pp_ifdef('use_titlecase')">
-        <message name="IDS_BOOMARK_BAR_OPEN_INCOGNITO" desc="Menu description for opening bookmark in incognito window">
-          Open in incognito window
-        </message>
         <message name="IDS_BOOMARK_BAR_OPEN_IN_NEW_TAB" desc="Menu description for loading bookmark in a new tab">
-          Open in new tab
+          &amp;Open in new tab
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_IN_NEW_WINDOW" desc="Menu description for loading bookmark in a new window">
-          Open in new window
+          Open in &amp;new window
+        </message>
+        <message name="IDS_BOOMARK_BAR_OPEN_INCOGNITO" desc="Menu description for opening bookmark in incognito window">
+          Open in &amp;incognito window
         </message>
         <message name="IDS_BOOMARK_BAR_ADD_NEW_BOOKMARK" desc="Menu title for adding a new bookmark entry">
-          Add page...
+          Add p&amp;age...

[Peter Kasting, 2011/08/09 22:10:46]

This conflicts with the 'A' for 'Always show bookmarks bar'.  Maybe use 'g'
instead?

[tfarina, 2011/08/09 23:58:48]

The 'A' doesn't work for me here on Linux.
When I change to 'g', strangely enough the underscore doesn't appear in the menu
item, but the keyboard accelerator works. So I didn't changed.

         </message>
         <message name="IDS_BOOMARK_BAR_NEW_FOLDER" desc="Menu title for adding a new folder">
-          Add folder...
+          Add &amp;folder...
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_ALL" desc="Menu title for opening all urls in a bookmark folder">
-          Open all bookmarks
+          &amp;Open all bookmarks
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW" desc="Menu title for opening all urls in a bookmark folder in a new window">
-          Open all bookmarks in new window
+          Open all bookmarks in &amp;new window
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_ALL_INCOGNITO" desc="Menu description for opening all urls in a bookmark folder in an incognito window">
-          Open all bookmarks in incognito window
+          Open all bookmarks in &amp;incognito window
         </message>
         <message name="IDS_BOOKMARK_BAR_REMOVE" desc="Menu title for removing/unstarring a bookmark">
-          Delete
+          &amp;Delete
         </message>
       </if>
       <if expr="pp_ifdef('use_titlecase')">
-        <message name="IDS_BOOMARK_BAR_OPEN_INCOGNITO" desc="In Title Case: Menu description for opening bookmark in incognito window">
-          Open in Incognito Window
-        </message>
         <message name="IDS_BOOMARK_BAR_OPEN_IN_NEW_TAB" desc="In Title Case: Menu description for loading bookmark in a new tab">
-          Open in New Tab
+          &amp;Open in New Tab
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_IN_NEW_WINDOW" desc="In Title Case: Menu description for loading bookmark in a new window">
-          Open in New Window
+          Open in &amp;New Window
+        </message>
+        <message name="IDS_BOOMARK_BAR_OPEN_INCOGNITO" desc="In Title Case: Menu description for opening bookmark in incognito window">
+          Open in &amp;Incognito Window
         </message>
         <message name="IDS_BOOMARK_BAR_ADD_NEW_BOOKMARK" desc="In Title Case: Menu title for adding a new bookmark entry">
-          Add Page...
+          Add P&amp;age...
         </message>
         <message name="IDS_BOOMARK_BAR_NEW_FOLDER" desc="In Title Case: Menu title for adding a new folder">
-          Add Folder...
+          Add &amp;Folder...
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_ALL" desc="In Title Case: Menu title for opening all urls in a bookmark folder">
-          Open All Bookmarks
+          &amp;Open All Bookmarks
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW" desc="In Title Case: Menu title for opening all urls in a bookmark folder in a new window">
-          Open All Bookmarks in New Window
+          Open All Bookmarks in &amp;New Window
         </message>
         <message name="IDS_BOOMARK_BAR_OPEN_ALL_INCOGNITO" desc="In Title Case: Menu description for opening all urls in a bookmark folder in an incognito window">
-          Open All Bookmarks in Incognito Window
+          Open All Bookmarks in &amp;Incognito Window
         </message>
         <message name="IDS_BOOKMARK_BAR_REMOVE" desc="In Title Case: Menu title for removing/unstarring a bookmark">
-          Delete
+          &amp;Delete
         </message>
       </if>
       <message name="IDS_BOOMARK_BAR_EDIT_FOLDER_LABEL" desc="Title of label before text field in edit folder dialog">
         Name:
       </message>
       <if expr="not pp_ifdef('use_titlecase')">
         <message name="IDS_BOOKMARK_BAR_EDIT"
                  desc="Title of the bookmark context menu item that brings up the bookmark editor">
-          Edit...
+          &amp;Edit...
         </message>
         <message name="IDS_BOOKMARK_BAR_RENAME_FOLDER"
                  desc="Title of the bookmark context menu item that brings up a dialog to rename a folder">
-          Rename...
+          &amp;Rename...
         </message>
       </if>
       <if expr="pp_ifdef('use_titlecase')">
         <message name="IDS_BOOKMARK_BAR_EDIT"
                  desc="In Title Case: Title of the bookmark context menu item that brings up the bookmark editor">
-          Edit...
+          &amp;Edit...
         </message>
         <message name="IDS_BOOKMARK_BAR_RENAME_FOLDER"
                  desc="In Title Case: Title of the bookmark context menu item that brings up a dialog to rename a folder">
-          Rename...
+          &amp;Rename...
         </message>
       </if>
       <message name="IDS_BOOKMARK_BAR_SHOULD_OPEN_ALL"
                desc="Message in the message box shown if user asks to open a lot of bookmarks in a folder">
         Are you sure you want to open <ph name="TAB_COUNT">$1<ex>20</ex></ph> tabs?
       </message>
 
       <!-- error page messages -->
       <message name="IDS_ERRORPAGES_SUGGESTION_HEADING" desc="Heading in the error page above the actual suggestions">
         Here are some suggestions:
@@ skipping 6988 matching lines @@
     </includes>
     <structures fallback_to_english="true">
       <structure name="IDD_CHROME_FRAME_FIND_DIALOG" file="cf_resources.rc" type="dialog" >
       </structure>
       <structure name="IDD_CHROME_FRAME_READY_PROMPT" file="cf_resources.rc" type="dialog" >
       </structure>
     </structures>
 
   </release>
 </grit>