Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 7575001: cros: Remove unneeded includes from update_library.h plus some random cleanups. (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

cros: Remove unneeded includes from update_library.h plus some random cleanups. BUG=None TEST=None R=stevenjb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95574

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -22 lines) Patch
M chrome/browser/chromeos/cros/update_library.h View 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/cros/update_library.cc View 3 chunks +10 lines, -11 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
9 years, 4 months ago (2011-08-04 01:58:30 UTC) #1
stevenjb
http://codereview.chromium.org/7575001/diff/1/chrome/browser/chromeos/cros/update_library.cc File chrome/browser/chromeos/cros/update_library.cc (right): http://codereview.chromium.org/7575001/diff/1/chrome/browser/chromeos/cros/update_library.cc#newcode19 chrome/browser/chromeos/cros/update_library.cc:19: Init(); We should make Init() virtual for this class ...
9 years, 4 months ago (2011-08-05 00:01:42 UTC) #2
tfarina
http://codereview.chromium.org/7575001/diff/1/chrome/browser/chromeos/cros/update_library.cc File chrome/browser/chromeos/cros/update_library.cc (right): http://codereview.chromium.org/7575001/diff/1/chrome/browser/chromeos/cros/update_library.cc#newcode19 chrome/browser/chromeos/cros/update_library.cc:19: Init(); On 2011/08/05 00:01:42, Steven Bennetts wrote: > We ...
9 years, 4 months ago (2011-08-05 00:03:53 UTC) #3
tfarina
On 2011/08/05 00:03:53, tfarina wrote: > http://codereview.chromium.org/7575001/diff/1/chrome/browser/chromeos/cros/update_library.cc > File chrome/browser/chromeos/cros/update_library.cc (right): > > http://codereview.chromium.org/7575001/diff/1/chrome/browser/chromeos/cros/update_library.cc#newcode19 > ...
9 years, 4 months ago (2011-08-05 00:22:18 UTC) #4
tfarina
9 years, 4 months ago (2011-08-05 04:10:22 UTC) #5
On Thu, Aug 4, 2011 at 9:24 PM,  <stevenjb@chromium.org> wrote:
> That's fine. LGTM.
>
>
> http://codereview.chromium.org/7575001/
>
Some how this didn't appear in rietveld. But I'm going to land as I
got it through email.


-- 
Thiago

Powered by Google App Engine
This is Rietveld 408576698