Remove frontend code that allows for dynamic profile setting, and read the profile off the browse...

Remove frontend code that allows for dynamic profile setting, and read the profile off the browser where possible.  This matches common practice and various invariants that expect profiles to be constant for the life of the browser.

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95889

[sky, 2011-08-08 16:02:29]

Nice. I'm a bit worried about timing related issues around shutdown. By that I
mean some objects asking other objects for the Profile instead of accessing a
local field so that if dependent objects go away there are problems. But if
there are issues like that, they can be dealt with later.

LGTM

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/gtk/bookm...
File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/gtk/bookm...
chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:291:
RemoveAllBookmarkButtons();
I don't think you need this anymore. It made sense in SetProfile, but not at
init time.

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.h (right):

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.h:402: // Owning browser.
This is NULL during testing.
Is the comment about NULL during testing applicable anymore?

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:228:
MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask);
Please add a comment as to why you need to do quit/run.

[Peter Kasting, 2011-08-08 17:52:07]

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/gtk/bookm...
File chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/gtk/bookm...
chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:291:
RemoveAllBookmarkButtons();
On 2011/08/08 16:02:29, sky wrote:
> I don't think you need this anymore. It made sense in SetProfile, but not at
> init time.

Unfortunately this function does more than removing all the buttons -- it also
adds back the "other bookmarks" and overflow buttons.

I think I'll rename it, though I don't know to what.

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.h (right):

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.h:402: // Owning browser.
This is NULL during testing.
On 2011/08/08 16:02:29, sky wrote:
> Is the comment about NULL during testing applicable anymore?

No.

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc (right):

http://codereview.chromium.org/7574021/diff/13023/chrome/browser/ui/views/boo...
chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc:228:
MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask);
On 2011/08/08 16:02:29, sky wrote:
> Please add a comment as to why you need to do quit/run.

Sure.