Removed oauth2_callback.html, merged functionality into remoting.js and improved 'No thanks' UX.

Removed oauth2_callback.html, merged functionality into remoting.js and improved 'No thanks' UX.

BUG=91719
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95531

[Jamie, 2011-08-04 21:33:27]

This CL improves the UX if the user cancels the authorization prompt. I've also
taken the opportunity to remove the oauth2_callback page, which didn't seem
necessary.

[awong, 2011-08-04 21:39:43]

LGTM

[Jamie, 2011-08-04 21:56:16]

As discussed, here's a version that clears the URL parameters if it detects an
OAuth2 redirect. I'm now less convinced that this is an improvement over the
previous design.

http://codereview.chromium.org/7574019/diff/3002/remoting/webapp/me2mom/remot...
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/7574019/diff/3002/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:167: return;
Does location.replace automatically terminate the script, or is this return
necessary?

[awong, 2011-08-04 22:42:36]

still LGTM

I agree...not seeing any real benefit over the interstitial.  My gut leans
towards keeping the auth flow nice and isolated in its own page, but don't feel
strongly. Will leave it up to you whether or not merging makes sense.

http://codereview.chromium.org/7574019/diff/3002/remoting/webapp/me2mom/remot...
File remoting/webapp/me2mom/remoting.js (right):

http://codereview.chromium.org/7574019/diff/3002/remoting/webapp/me2mom/remot...
remoting/webapp/me2mom/remoting.js:167: return;
On 2011/08/04 21:56:16, Jamie wrote:
> Does location.replace automatically terminate the script, or is this return
> necessary?

I think it does go immediately, but the return still looks cleaner to me.

[Jamie, 2011-08-04 23:08:34]

I agree. If nothing else, it's faster to load the interstitial. Sorry to ask for
yet another LGTM, but since my  approach has changed, I feel it needs one :)

[awong, 2011-08-04 23:11:02]

LGTM++ :P