Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 7574008: Specify stack size for win64 when linking d8. (Closed)

Created:
9 years, 4 months ago by Yang
Modified:
9 years, 4 months ago
Reviewers:
Rico, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Specify stack size for win64 when linking d8. Committed: http://code.google.com/p/v8/source/detail?r=8841

Patch Set 1 #

Total comments: 2

Patch Set 2 : v8.gyp instead of common.gypi #

Patch Set 3 : Removed changed concerning d8 in gyp build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -3 lines) Patch
M SConstruct View 4 chunks +54 lines, -3 lines 0 comments Download
M build/common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
PTAL. This should take care of buildbot failures for Win64. http://codereview.chromium.org/7574008/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/7574008/diff/1/SConstruct#newcode439 ...
9 years, 4 months ago (2011-08-04 12:18:38 UTC) #1
Yang
As Jakob mentioned, putting the stack size option into v8.gyp instead of common.gypi would help ...
9 years, 4 months ago (2011-08-04 15:17:19 UTC) #2
Rico
LGTM http://codereview.chromium.org/7574008/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/7574008/diff/1/SConstruct#newcode875 SConstruct:875: } All this is just verbatim copy from ...
9 years, 4 months ago (2011-08-05 06:01:13 UTC) #3
Yang
Rico: yes, it's a verbatim copy from the shell flags. Jakob: I removed the stuff ...
9 years, 4 months ago (2011-08-05 07:47:47 UTC) #4
Jakob Kummerow
9 years, 4 months ago (2011-08-05 09:53:56 UTC) #5
LGTM.

I guess it would be a good idea to at least put a comment into one of the .gyp
files indicating that we'll need to add that stacksize parameter when we want to
build 64bit Windows binaries.

Powered by Google App Engine
This is Rietveld 408576698