Issue 7574007: Require a default parent to use some Views implementations on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7574007: Require a default parent to use some Views implementations on ChromeOS. (Closed)

Created:
9 years, 4 months ago by kinaba

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, Ben Goodger (Google), Emmanuel Saint-loubert-Bié

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Require a default parent to use some Views implementations on ChromeOS. Toplevel widgets need to be a native widget even when --use-pure-views. BUG=None TEST=No crashes on start-up with --use-pure-views. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95594

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/views/tab_contents/native_tab_contents_view_gtk.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinaba

Exactly the same workaround as http://codereview.chromium.org/7285027 on Windows, complementing a partial workaround of http://codereview.chromium.org/7210037 on ...

9 years, 4 months ago (2011-08-04 11:16:09 UTC) #1

kinaba

Oops, Ben seems ooo. Emmanuel, can you reviews this? Thanks.

9 years, 4 months ago (2011-08-05 01:15:47 UTC) #2

Change committed as 95594

Expand Messages | Collapse Messages