options: Get rid of OptionsPage enum as it's no longer used.

options: Get rid of OptionsPage enum as it's no longer used.

BUG=None
TEST=None

R=evan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95477

[Evan Martin, 2011-08-04 15:37:55]

I feel a little weird reviewing code that I didn't write.  Maybe ask
the author of this code for a review?

On Wed, Aug 3, 2011 at 7:53 PM,  <tfarina@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> options: Get rid of OptionsPage enum as it's no longer used.
>
> BUG=None
> TEST=None
>
> R=evan@chromium.org
>
>
> Please review this at http://codereview.chromium.org/7574004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/options/options_util.h
>
>
> Index: chrome/browser/ui/options/options_util.h
> diff --git a/chrome/browser/ui/options/options_util.h
> b/chrome/browser/ui/options/options_util.h
> index
>
4a7a8016b23d21fcdfc1e2396ade0553845ffb52..8bae87bdac789ad5bee60f60104155f5738be3eb
> 100644
> --- a/chrome/browser/ui/options/options_util.h
> +++ b/chrome/browser/ui/options/options_util.h
> @@ -8,22 +8,6 @@
>
>  #include "base/basictypes.h"
>
> -// An identifier for an Options Tab page. These are treated as indices into
> -// the list of available tabs to be displayed. PAGE_DEFAULT means select
> the
> -// last tab viewed when the Options window was opened, or PAGE_GENERAL if
> the
> -// Options was never opened.
> -enum OptionsPage {
> -  OPTIONS_PAGE_DEFAULT = -1,
> -#if defined(OS_CHROMEOS)
> -  OPTIONS_PAGE_SYSTEM,
> -  OPTIONS_PAGE_INTERNET,
> -#endif
> -  OPTIONS_PAGE_GENERAL,
> -  OPTIONS_PAGE_CONTENT,
> -  OPTIONS_PAGE_ADVANCED,
> -  OPTIONS_PAGE_COUNT
> -};
> -
>  class OptionsUtil {
>  public:
>   // Try to make the the crash stats consent and the metrics upload
>
>
>

[tfarina, 2011-08-04 15:41:12]

On 2011/08/04 15:37:55, Evan Martin wrote:
> I feel a little weird reviewing code that I didn't write.  Maybe ask
> the author of this code for a review?
> 
+mattm for review.

[mattm, 2011-08-04 20:12:50]

lgtm