chrome/browser/ui/webui/web_ui_browsertest.cc - Issue 7574002: Be able to print items that do window.print(); window.close() (airline tix e.g.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/web_ui_browsertest.cc

Issue 7574002: Be able to print items that do window.print(); window.close() (airline tix e.g.) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Lei's comments. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/background_printing_manager.cc ('K') | « chrome/browser/ui/webui/web_ui_browsertest.h ('k') | chrome/test/data/webui/print_preview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/web_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/web_ui_browsertest.cc b/chrome/browser/ui/webui/web_ui_browsertest.cc

index 96204d134809ab658afea8db38c32642bb9835b8..3fd98b38375104928df736c935002e8a8d187127 100644

--- a/chrome/browser/ui/webui/web_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/web_ui_browsertest.cc

@@ -190,16 +190,20 @@ void WebUIBrowserTest::BrowsePreload(const GURL& browse_to,

void WebUIBrowserTest::BrowsePrintPreload(

const GURL& browse_to,

const std::string& preload_test_fixture,

- const std::string& preload_test_name) {

+ const std::string& preload_test_name,

+ bool print) {

// Remember for callback OnJsInjectionReady().

preload_test_fixture_ = preload_test_fixture;

preload_test_name_ = preload_test_name;

- ui_test_utils::NavigateToURL(browser(), browse_to);

TestTabStripModelObserver tabstrip_observer(

browser()->tabstrip_model(), this);

- browser()->Print();

+ ui_test_utils::NavigateToURL(browser(), browse_to);

+ if (print)

+ browser()->Print();

tabstrip_observer.WaitForObservation();

}