Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7574002: Be able to print items that do window.print(); window.close() (airline tix e.g.) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Lei's comments. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc
index b41638004013b778dac780b3b3eccce3626659fb..ea826c13d3a989ef3c8b5ea4237449fbce9fd79c 100644
--- a/chrome/browser/ui/webui/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview_handler.cc
@@ -930,9 +930,11 @@ void PrintPreviewHandler::FileSelectionCanceled(void* params) {
void PrintPreviewHandler::HidePreviewTab() {
TabContentsWrapper* preview_tab_wrapper =
TabContentsWrapper::GetCurrentWrapperForContents(preview_tab());
- if (GetBackgroundPrintingManager()->HasTabContents(preview_tab_wrapper))
+ if (GetBackgroundPrintingManager()->HasPreviewTabContents(
+ preview_tab_wrapper))
return;
- GetBackgroundPrintingManager()->OwnTabContents(preview_tab_wrapper);
+
+ GetBackgroundPrintingManager()->OwnPreviewTabContents(preview_tab_wrapper);
}
void PrintPreviewHandler::ClearInitiatorTabDetails() {
@@ -945,6 +947,11 @@ void PrintPreviewHandler::ClearInitiatorTabDetails() {
// another preview tab.
printing::PrintPreviewTabController* tab_controller =
printing::PrintPreviewTabController::GetInstance();
- if (tab_controller)
+ if (tab_controller) {
+ TabContentsWrapper* initiator_wrapper =
+ TabContentsWrapper::GetCurrentWrapperForContents(initiator_tab);
tab_controller->EraseInitiatorTabInfo(preview_tab());
+ GetBackgroundPrintingManager()->ReleaseInitiatorTabContents(
+ initiator_wrapper);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698