chrome/browser/printing/print_preview_message_handler.cc - Issue 7574002: Be able to print items that do window.print(); window.close() (airline tix e.g.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_message_handler.cc

Issue 7574002: Be able to print items that do window.print(); window.close() (airline tix e.g.) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed Lei's comments. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/background_printing_manager.cc ('K') | « chrome/browser/printing/background_printing_manager.cc ('k') | chrome/browser/printing/print_preview_tab_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_message_handler.cc

diff --git a/chrome/browser/printing/print_preview_message_handler.cc b/chrome/browser/printing/print_preview_message_handler.cc

index a9462e9afc2aad8b90be41785540844cd2870ca5..17ac65f959356cc2b82dcd640341444c24167662 100644

--- a/chrome/browser/printing/print_preview_message_handler.cc

+++ b/chrome/browser/printing/print_preview_message_handler.cc

@@ -185,7 +185,7 @@ void PrintPreviewMessageHandler::OnPrintPreviewFailed(int document_cookie) {

TabContentsWrapper::GetCurrentWrapperForContents(print_preview_tab);

if (g_browser_process->background_printing_manager()->

- HasTabContents(wrapper)) {

+ HasPreviewTabContents(wrapper)) {

// Preview tab was hidden to serve the print request.

delete wrapper;

} else {