Be able to print items that do window.print(); window.close() (airline tix e.g.)

chrome/browser/printing/background_printing_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/background_printing_manager.h"
 
 #include "chrome/browser/printing/print_job.h"
 #include "chrome/browser/printing/print_preview_tab_controller.h"
 #include "chrome/browser/sessions/restore_tab_helper.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
@@ skipping 11 matching lines @@
 }
 
 BackgroundPrintingManager::~BackgroundPrintingManager() {
   DCHECK(CalledOnValidThread());
   // The might be some TabContentsWrappers still in |printing_contents_| at
   // this point. E.g. when the last remaining tab is a print preview tab and
   // tries to print. In which case it will fail to print.
   // TODO(thestig) handle this case better.
 }
 
-void BackgroundPrintingManager::OwnTabContents(TabContentsWrapper* contents) {
+void BackgroundPrintingManager::OwnPreviewTabContents(
+    TabContentsWrapper* content) {

[Lei Zhang, 2011/08/26 10:01:54]

This should be "contents" to be consistent with the rest of the file and the
rest of the project.

[Sheridan Rawlins, 2011/08/26 23:45:39]

Done.

   DCHECK(CalledOnValidThread());
   DCHECK(printing::PrintPreviewTabController::IsPrintPreviewTab(
-      contents->tab_contents()));
-  CHECK(printing_contents_.find(contents) == printing_contents_.end());
+      content->tab_contents()));
+  CHECK(printing_contents_.find(content) == printing_contents_.end());
 
-  printing_contents_.insert(contents);
-
-  registrar_.Add(this, chrome::NOTIFICATION_PRINT_JOB_RELEASED,
-                 Source<TabContentsWrapper>(contents));
-  registrar_.Add(this, content::NOTIFICATION_TAB_CONTENTS_DESTROYED,
-                 Source<TabContents>(contents->tab_contents()));
-
-  // Detach |contents| from its tab strip.
-  Browser* browser = BrowserList::FindBrowserWithID(
-      contents->restore_tab_helper()->window_id().id());
-  DCHECK(browser);
-
-  TabStripModel* tabstrip = browser->tabstrip_model();
-  tabstrip->DetachTabContentsAt(tabstrip->GetIndexOfTabContents(contents));
-
-  // Activate the initiator tab.
+  // Find the initiator tab.
+  TabContents* initiator_tab = NULL;
+  TabContentsWrapper* initiator_tab_wrapper = NULL;
   printing::PrintPreviewTabController* tab_controller =
       printing::PrintPreviewTabController::GetInstance();
-  if (!tab_controller)
-    return;
-  TabContents* initiator_tab = tab_controller->GetInitiatorTab(
-      contents->tab_contents());
-  if (!initiator_tab)
-    return;
-  static_cast<RenderViewHostDelegate*>(initiator_tab)->Activate();
+  if (tab_controller)
+    initiator_tab = tab_controller->GetInitiatorTab(content->tab_contents());
+  if (initiator_tab) {
+    initiator_tab_wrapper =
+        TabContentsWrapper::GetCurrentWrapperForContents(initiator_tab);
+  }
+
+  bool initiator_tab_exists = initiator_tab_wrapper &&
+      !ReleaseInitiatorTabContents(initiator_tab_wrapper);
+  OwnTabContents(content, content, &printing_contents_);
+  // Activate the initiator tab if it exists.
+  if (initiator_tab_exists)
+    static_cast<RenderViewHostDelegate*>(initiator_tab)->Activate();
+}
+
+bool BackgroundPrintingManager::OwnInitiatorTabContents(
+    TabContentsWrapper* content) {
+  DCHECK(CalledOnValidThread());
+  DCHECK(!printing::PrintPreviewTabController::IsPrintPreviewTab(
+      content->tab_contents()));
+
+  printing::PrintPreviewTabController* tab_controller =
+      printing::PrintPreviewTabController::GetInstance();

[Lei Zhang, 2011/08/26 10:01:54]

check the return value

[Sheridan Rawlins, 2011/08/26 23:45:39]

Done.

+  TabContents* preview_tab =
+      tab_controller->GetPrintPreviewForTab(content->tab_contents());
+  if (!preview_tab)
+    return false;
+  TabContentsWrapper* preview_contents =
+      TabContentsWrapper::GetCurrentWrapperForContents(preview_tab);
+
+  OwnTabContents(content, preview_contents, &initiator_contents_);
+
+  return true;
+}
+
+bool BackgroundPrintingManager::ReleaseInitiatorTabContents(
+    TabContentsWrapper* content) {
+  if (initiator_contents_.find(content) == initiator_contents_.end())
+    return false;
+
+  initiator_contents_.erase(content);
+  MessageLoop::current()->DeleteSoon(FROM_HERE, content);
+  return true;
 }
 
 void BackgroundPrintingManager::Observe(int type,
                                         const NotificationSource& source,
                                         const NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_PRINT_JOB_RELEASED: {
       TabContentsWrapper* tab = Source<TabContentsWrapper>(source).ptr();
       registrar_.Remove(this, chrome::NOTIFICATION_PRINT_JOB_RELEASED,
                         Source<TabContentsWrapper>(tab));
 
       // This might be happening in the middle of a RenderViewGone() loop.
       // Deleting |contents| later so the RenderViewGone() loop can finish.
       MessageLoop::current()->DeleteSoon(FROM_HERE, tab);
+      ReleaseInitiatorForPreviewTabContents(tab);
       break;
     }
     case content::NOTIFICATION_TAB_CONTENTS_DESTROYED: {
       TabContentsWrapper* tab =
           TabContentsWrapper::GetCurrentWrapperForContents(
               Source<TabContents>(source).ptr());
       if (registrar_.IsRegistered(this, chrome::NOTIFICATION_PRINT_JOB_RELEASED,
                                   Source<TabContentsWrapper>(tab))) {
         registrar_.Remove(this, chrome::NOTIFICATION_PRINT_JOB_RELEASED,
                           Source<TabContentsWrapper>(tab));
       }
       registrar_.Remove(this, content::NOTIFICATION_TAB_CONTENTS_DESTROYED,
                         Source<TabContents>(tab->tab_contents()));
       printing_contents_.erase(tab);
+      ReleaseInitiatorForPreviewTabContents(tab);
       break;
     }
     default: {
       NOTREACHED();
       break;
     }
   }
 }
 
-std::set<TabContentsWrapper*>::const_iterator
+bool BackgroundPrintingManager::ReleaseInitiatorForPreviewTabContents(
+    TabContentsWrapper* preview_content) {
+  DCHECK(CalledOnValidThread());
+  printing::PrintPreviewTabController* tab_controller =
+      printing::PrintPreviewTabController::GetInstance();
+
+  if (!tab_controller)
+    return false;
+
+  TabContents* initiator_tab = tab_controller->GetInitiatorTab(
+      preview_content->tab_contents());
+  if (!initiator_tab)
+    return false;
+
+  TabContentsWrapper* initiator_wrapper =
+      TabContentsWrapper::GetCurrentWrapperForContents(initiator_tab);
+
+  return ReleaseInitiatorTabContents(initiator_wrapper);
+}
+
+void BackgroundPrintingManager::OwnTabContents(
+    TabContentsWrapper* contents,
+    TabContentsWrapper* source_contents,
+    TabContentsWrapperSet* wrapper_set) {
+  DCHECK(source_contents);
+  DCHECK(printing::PrintPreviewTabController::IsPrintPreviewTab(
+      source_contents->tab_contents()));
+  CHECK(wrapper_set->find(contents) == wrapper_set->end());

[Lei Zhang, 2011/08/26 10:01:54]

You should either just do this CHECK here, do it in OwnFoo and not here.

[Sheridan Rawlins, 2011/08/26 23:45:39]

Done.

+
+  wrapper_set->insert(contents);
+
+  if (source_contents) {

[Lei Zhang, 2011/08/26 10:01:54]

I don't think this will ever be false in this private method. I bet you can
assert this by changing line 150 to a CHECK.

[Sheridan Rawlins, 2011/08/26 23:45:39]

Done.

+    if (!registrar_.IsRegistered(this, chrome::NOTIFICATION_PRINT_JOB_RELEASED,
+                                 Source<TabContentsWrapper>(source_contents))) {
+      registrar_.Add(this, chrome::NOTIFICATION_PRINT_JOB_RELEASED,
+                     Source<TabContentsWrapper>(source_contents));
+    }
+    if (!registrar_.IsRegistered(
+            this, content::NOTIFICATION_TAB_CONTENTS_DESTROYED,
+            Source<TabContents>(source_contents->tab_contents()))) {
+      registrar_.Add(this, content::NOTIFICATION_TAB_CONTENTS_DESTROYED,
+                     Source<TabContents>(source_contents->tab_contents()));
+    }
+  }
+
+  // Detach |contents| from its tab strip.
+  Browser* browser = BrowserList::FindBrowserWithID(
+      contents->restore_tab_helper()->window_id().id());
+  DCHECK(browser);
+
+  TabStripModel* tabstrip = browser->tabstrip_model();
+  tabstrip->DetachTabContentsAt(tabstrip->GetIndexOfTabContents(contents));
+}
+
+BackgroundPrintingManager::TabContentsWrapperSet::const_iterator
     BackgroundPrintingManager::begin() {
   return printing_contents_.begin();
 }
 
-std::set<TabContentsWrapper*>::const_iterator
+BackgroundPrintingManager::TabContentsWrapperSet::const_iterator
     BackgroundPrintingManager::end() {
   return printing_contents_.end();
 }
 
 bool BackgroundPrintingManager::HasTabContents(TabContentsWrapper* entry) {
   return printing_contents_.find(entry) != printing_contents_.end();
 }
 
 }  // namespace printing