Fix subtle memory issues detected by valgrind.

Fix subtle memory issues detected by valgrind.

The size of dbus_bool_t and the size of bool are different.
The former is always 4, whereas the latter is usually 1.

The misuse of these types causes subtle memory issues
where some D-Bus functions read 4 bytes from a bool pointer,
or write 4 bytes to it. These functions take void* so
type checking didn't help.

TEST=tools/valgrind/valgrind.sh ninja/dbus_unittests
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95512

[stevenjb, 2011-08-03 20:39:59]

http://codereview.chromium.org/7573001/diff/1/dbus/message.cc
File dbus/message.cc (right):

http://codereview.chromium.org/7573001/diff/1/dbus/message.cc#newcode489
dbus/message.cc:489: *value = dbus_value;
on some compilers this may require a static_cast<> (probably a good idea
anyway).

http://codereview.chromium.org/7573001/diff/1/dbus/message.cc#newcode589
dbus/message.cc:589: *value = dbus_value;
static_cast

[satorux1, 2011-08-03 20:43:04]

http://codereview.chromium.org/7573001/diff/1/dbus/message.cc
File dbus/message.cc (right):

http://codereview.chromium.org/7573001/diff/1/dbus/message.cc#newcode489
dbus/message.cc:489: *value = dbus_value;
On 2011/08/03 20:40:00, Steven Bennetts wrote:
> on some compilers this may require a static_cast<> (probably a good idea
> anyway).

Done.

http://codereview.chromium.org/7573001/diff/1/dbus/message.cc#newcode589
dbus/message.cc:589: *value = dbus_value;
On 2011/08/03 20:40:00, Steven Bennetts wrote:
> static_cast

Done.

[stevenjb, 2011-08-03 20:46:05]

lgtm

[commit-bot: I haz the power, 2011-08-04 21:57:22]

Change committed as 95512