Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 7572047: Remeber active tab in tab bar instead of 'this'. (Closed)

Created:
9 years, 4 months ago by xiyuan
Modified:
9 years, 4 months ago
Reviewers:
csilv, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Remeber active tab in tab bar instead of 'this'. OptionsPage.showTab could be called with wrong 'this' so remember activeNavTab in parent tab bar instead. BUG=chromium-os:18662 TEST=Verify fix for chromium-os:18662. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/resources/options/options_page.js View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
9 years, 4 months ago (2011-08-05 22:56:40 UTC) #1
csilv
9 years, 4 months ago (2011-08-05 23:05:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698