Be a little more careful whether something is an URL or a file path.

Be a little more careful whether something is an URL or a file path.

BUG=72492
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95731

[Chris Evans, 2011-08-05 19:27:06]

You're the OWNER I recognized best :)

[Chris Evans, 2011-08-05 22:03:50]

Oops, Eric is out. Trying a different reviewer :)

[jar (doing other things), 2011-08-06 02:33:27]

http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
File chrome/browser/net/url_fixer_upper.cc (right):

http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
chrome/browser/net/url_fixer_upper.cc:542: GURL gurl(text.value());
Why did you use |text| instead of |trimmed|?

http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
File chrome/browser/net/url_fixer_upper_unittest.cc (right):

http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
chrome/browser/net/url_fixer_upper_unittest.cc:520: // test than an obvious HTTP
URL isn't accidentally treated as an absolute
nit: Comments should be sentences, starting with upper case, and ending with
periods (even if the other comments had a strange style.... and should be
fixed... by some other CL.)

[jar (doing other things), 2011-08-06 02:45:31]

LGTM with transition to |trimmed|, plus nit fix.

Thanks!

On 2011/08/06 02:33:27, jar wrote:
>
http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
> File chrome/browser/net/url_fixer_upper.cc (right):
> 
>
http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
> chrome/browser/net/url_fixer_upper.cc:542: GURL gurl(text.value());
> Why did you use |text| instead of |trimmed|?
> 
>
http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
> File chrome/browser/net/url_fixer_upper_unittest.cc (right):
> 
>
http://codereview.chromium.org/7572046/diff/1/chrome/browser/net/url_fixer_up...
> chrome/browser/net/url_fixer_upper_unittest.cc:520: // test than an obvious
HTTP
> URL isn't accidentally treated as an absolute
> nit: Comments should be sentences, starting with upper case, and ending with
> periods (even if the other comments had a strange style.... and should be
> fixed... by some other CL.)

[jar (doing other things), 2011-08-06 02:46:29]

LGTM