ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm - Issue 7572031: Always call the class methods to save/restore contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm

Issue 7572031: Always call the class methods to save/restore contexts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ensure saving before context access Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm

diff --git a/ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm b/ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm

index f3992ea0b694a520c9b45b869151144d4237836b..395bbc4ff6b49bff134d135a5b153554853e5d0f 100644

--- a/ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm

+++ b/ui/gfx/scoped_ns_graphics_context_save_gstate_mac.mm

@@ -8,15 +8,12 @@

namespace gfx {

-ScopedNSGraphicsContextSaveGState::ScopedNSGraphicsContextSaveGState(

- NSGraphicsContext* context) : context_([context retain]) {

- if (!context_)

- context_.reset([[NSGraphicsContext currentContext] retain]);

- [context_ saveGraphicsState];

+ScopedNSGraphicsContextSaveGState::ScopedNSGraphicsContextSaveGState() {

+ [NSGraphicsContext saveGraphicsState];

}

ScopedNSGraphicsContextSaveGState::~ScopedNSGraphicsContextSaveGState() {

- [context_ restoreGraphicsState];

+ [NSGraphicsContext restoreGraphicsState];

}

} // namespace gfx