chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm - Issue 7572031: Always call the class methods to save/restore contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

Issue 7572031: Always call the class methods to save/restore contexts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ensure saving before context access Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

index 6be1a30c5e130dc140071f68a49dbc07ce8cd0be..6cbdd0ae2323984b13186e354b18ad06bee46512 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

@@ -56,8 +56,8 @@ const CGFloat kBorderRadius = 3.0;

if (!themeProvider)

return;

+ gfx::ScopedNSGraphicsContextSaveGState scopedGState;

NSGraphicsContext* context = [NSGraphicsContext currentContext];

- gfx::ScopedNSGraphicsContextSaveGState scopedGState(context);

// Draw the background.

{

@@ -103,7 +103,7 @@ const CGFloat kBorderRadius = 3.0;

// Fade in/out the background.

{

- gfx::ScopedNSGraphicsContextSaveGState bgScopedState(context);

+ gfx::ScopedNSGraphicsContextSaveGState bgScopedState;

[border setClip];

CGContextRef cgContext = (CGContextRef)[context graphicsPort];

Mark Mentovai 2011/08/04 23:20:17 Does [NSGraphicContext currentContext] belong righ

Avi (use Gerrit) 2011/08/05 00:18:50 Done.

CGContextBeginTransparencyLayer(cgContext, NULL);