Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3752)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7572022: Use bookmark manager to add/edit bookmark pages with webui_dialogs=1. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Reviewer cleanup. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 2de9e928ffd4f6f89a58d95c598c756628db7124..5c071b4fb55ac6a0ef6fc2b4a873724d35ce291c 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1948,12 +1948,28 @@ void Browser::OpenBookmarkManager() {
GetSingletonTabNavigateParams(GURL(chrome::kChromeUIBookmarksURL)));
}
-void Browser::OpenBookmarkManagerForNode(int64 node_id) {
+void Browser::OpenBookmarkManagerWithHash(const std::string& action,
+ int64 node_id) {
UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"));
UserMetrics::RecordAction(UserMetricsAction("ShowBookmarks"));
- ShowSingletonTabOverwritingNTP(
- GetSingletonTabNavigateParams(GURL(chrome::kChromeUIBookmarksURL).Resolve(
- StringPrintf("/#%s", base::Int64ToString(node_id).c_str()))));
+ browser::NavigateParams params(GetSingletonTabNavigateParams(
+ GURL(chrome::kChromeUIBookmarksURL).Resolve(
+ StringPrintf("/#%s%s", action.c_str(),
+ base::Int64ToString(node_id).c_str()))));
+ params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
+ ShowSingletonTabOverwritingNTP(params);
+}
+
+void Browser::OpenBookmarkManagerForNode(int64 node_id) {
+ OpenBookmarkManagerWithHash("", node_id);
+}
+
+void Browser::OpenBookmarkManagerEditNode(int64 node_id) {
+ OpenBookmarkManagerWithHash("e=", node_id);
+}
+
+void Browser::OpenBookmarkManagerAddNodeIn(int64 node_id) {
+ OpenBookmarkManagerWithHash("a=", node_id);
}
void Browser::ShowAppMenu() {

Powered by Google App Engine
This is Rietveld 408576698