Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: chrome/browser/ui/browser.cc

Issue 7572022: Use bookmark manager to add/edit bookmark pages with webui_dialogs=1. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index dd015aa3adc0c859ad8682538fa3f980aedf64ac..0771b4597cd24c5dbac34a329b449670f4dd3570 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1955,6 +1955,22 @@ void Browser::OpenBookmarkManagerForNode(int64 node_id) {
StringPrintf("/#%s", base::Int64ToString(node_id).c_str()))));
}
+void Browser::OpenBookmarkManagerEditNode(int64 node_id) {
+ UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"));
Rick Byers 2011/08/04 18:26:07 Avoid the duplicated code here - make all 3 functi
flackr 2011/08/12 18:11:24 Done.
+ UserMetrics::RecordAction(UserMetricsAction("ShowBookmarks"));
+ ShowSingletonTabOverwritingNTP(
+ GetSingletonTabNavigateParams(GURL(chrome::kChromeUIBookmarksURL).Resolve(
arv (Not doing code reviews) 2011/08/11 22:32:22 fix indentation
flackr 2011/08/12 18:11:24 Done.
+ StringPrintf("/#e=%s", base::Int64ToString(node_id).c_str()))));
+}
+
+void Browser::OpenBookmarkManagerAddNodeIn(int64 node_id) {
+ UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"));
+ UserMetrics::RecordAction(UserMetricsAction("ShowBookmarks"));
+ ShowSingletonTabOverwritingNTP(
+ GetSingletonTabNavigateParams(GURL(chrome::kChromeUIBookmarksURL).Resolve(
arv (Not doing code reviews) 2011/08/11 22:32:22 here too
flackr 2011/08/12 18:11:24 Done.
+ StringPrintf("/#a=%s", base::Int64ToString(node_id).c_str()))));
+}
+
void Browser::ShowAppMenu() {
// We record the user metric for this event in WrenchMenu::RunMenu.
window_->ShowAppMenu();

Powered by Google App Engine
This is Rietveld 408576698