Use bookmark manager to add/edit bookmark pages with webui_dialogs=1.

chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.h"
 
 #include "base/compiler_specific.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/bookmarks/bookmark_editor.h"
 #include "chrome/browser/bookmarks/bookmark_folder_editor_controller.h"
@@ skipping 111 matching lines @@
     case IDC_BOOKMARK_BAR_EDIT:
       UserMetrics::RecordAction(
           UserMetricsAction("BookmarkBar_ContextMenu_Edit"));
 
       if (selection_.size() != 1) {
         NOTREACHED();
         return;
       }
 
       if (selection_[0]->is_url()) {
+#if defined(WEBUI_BOOKMARK_EDITOR)

[Rick Byers, 2011/08/04 18:26:07]

You've really had to sprinkle this #ifdef in a lot of places.  Maybe you could
come up with a nice helper function for launching the bookmark editor (with some
param for add/edit/etc) that you call everywhere?  Not sure what this would look
like exactly, but in general sprinkling a bunch of ifdefs sucks...

[flackr, 2011/08/12 18:11:24]

I completely agree. As we discussed I think a slight refactoring of the base
BookmarkEditor::Show method will be the best way to handle this. I left a TODO
regarding this in that class (and in the common.gypi file with regards to using
a runtime flag) and will work on it in a subsequent CL.

+        Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
+        DCHECK(browser);
+        browser->OpenBookmarkManagerEditNode(selection_[0]->id());
+#else
         BookmarkEditor::Show(parent_widget_->GetNativeWindow(), profile_,
             parent_, BookmarkEditor::EditDetails(selection_[0]),
             BookmarkEditor::SHOW_TREE);
+#endif
       } else {
         BookmarkFolderEditorController::Show(profile_,
             parent_widget_->GetNativeWindow(), selection_[0], -1,
             BookmarkFolderEditorController::EXISTING_BOOKMARK);
       }
       break;
 
     case IDC_BOOKMARK_BAR_REMOVE: {
       UserMetrics::RecordAction(
           UserMetricsAction("BookmarkBar_ContextMenu_Remove"));
 
       delegate_->WillRemoveBookmarks(selection_);
       for (size_t i = 0; i < selection_.size(); ++i) {
         model->Remove(selection_[i]->parent(),
                       selection_[i]->parent()->GetIndexOf(selection_[i]));
       }
       delegate_->DidRemoveBookmarks();
       selection_.clear();
       break;
     }
 
     case IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK: {
       UserMetrics::RecordAction(
           UserMetricsAction("BookmarkBar_ContextMenu_Add"));
 
+#if defined(WEBUI_BOOKMARK_EDITOR)
+      Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
+      DCHECK(browser);
+      browser->OpenBookmarkManagerAddNodeIn(selection_[0]->id());
+#else
       // TODO: this should honor the index from GetParentForNewNodes.
       BookmarkEditor::Show(
           parent_widget_->GetNativeWindow(), profile_,
           bookmark_utils::GetParentForNewNodes(parent_, selection_, NULL),
           BookmarkEditor::EditDetails(), BookmarkEditor::SHOW_TREE);
+#endif
       break;
     }
 
     case IDC_BOOKMARK_BAR_NEW_FOLDER: {
       UserMetrics::RecordAction(
           UserMetricsAction("BookmarkBar_ContextMenu_NewFolder"));
       int index;
       const BookmarkNode* parent =
           bookmark_utils::GetParentForNewNodes(parent_, selection_, &index);
       BookmarkFolderEditorController::Show(profile_,
@@ skipping 114 matching lines @@
   return model;
 }
 
 bool BookmarkContextMenuControllerViews::HasURLs() const {
   for (size_t i = 0; i < selection_.size(); ++i) {
     if (bookmark_utils::NodeHasURLs(selection_[i]))
       return true;
   }
   return false;
 }