Use bookmark manager to add/edit bookmark pages with webui_dialogs=1.

build/common.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 17 matching lines @@
           # This turns on the TOOLKIT_USES_PURE_VIEWS macro which is used
           # to replace the corresponding GTK implementation in such a way
           # that GTK and PureViews can coexist. This intermediate solution
           # allow us to switch the view implementations using
           # --use-pure-views, without breaking exiting gtk implementation.
           'toolkit_uses_pure_views%': 0,
 
           # Disable touch support by default.
           'touchui%': 0,
 
+          # Disable webui bookmark editor until completion.

[Rick Byers, 2011/08/04 18:26:07]

Perhaps we should consider combining these now into a general "webui dialogs"
flag?  Is there value to you in keeping them separate?  If so, feel free - but I
think we should avoid unnecessary flag-pollution.

[flackr, 2011/08/12 18:11:24]

Done.

+          'webui_bookmark_editor%': 0,
+
           # Disable webui certificate viewer until it is complete.
           'webui_certificate_viewer%': 0,
 
           # Whether the compositor is enabled on views.
           'views_compositor%': 0,
         },
         # Copy conditionally-set variables out one scope.
         'chromeos%': '<(chromeos)',
         'toolkit_uses_pure_views%': '<(toolkit_uses_pure_views)',
         'touchui%': '<(touchui)',
+        'webui_bookmark_editor%': '<(webui_bookmark_editor)',
         'webui_certificate_viewer%': '<(webui_certificate_viewer)',
         'views_compositor%': '<(views_compositor)',
 
         # Compute the architecture that we're building on.
         'conditions': [
           [ 'OS=="win" or OS=="mac"', {
             'host_arch%': 'ia32',
           }, {
             # This handles the Unix platforms for which there is some support.
             # Anything else gets passed through, which probably won't work very
@@ skipping 10 matching lines @@
             'toolkit_views%': 0,
           }],
 
           # Views are always Pure in Touch case
           ['touchui==1', {
             'toolkit_uses_pure_views%': 1,
           }, {
             'toolkit_uses_pure_views%': 0,
           }],
 
           # Use WebUI certificate viewer in Touch case

[Rick Byers, 2011/08/04 18:26:07]

update comment

[flackr, 2011/08/12 18:11:24]

Done.

           ['touchui==1', {
-            'webui_certificate_viewer%': 1
+            'webui_certificate_viewer%': 1,
+            'webui_bookmark_editor%': 1,
           }],
         ],
       },
 
       # Copy conditionally-set variables out one scope.
       'chromeos%': '<(chromeos)',
       'touchui%': '<(touchui)',
+      'webui_bookmark_editor%': '<(webui_bookmark_editor)',
       'webui_certificate_viewer%': '<(webui_certificate_viewer)',
       'host_arch%': '<(host_arch)',
       'toolkit_views%': '<(toolkit_views)',
       'toolkit_uses_pure_views%': '<(toolkit_uses_pure_views)',
       'views_compositor%': '<(views_compositor)',
       # Whether to build for Wayland display server
       'use_wayland%': 0,
 
       # We used to provide a variable for changing how libraries were built.
       # This variable remains until we can clean up all the users.
@@ skipping 174 matching lines @@
     'views_compositor%': '<(views_compositor)',
     'os_posix%': '<(os_posix)',
     'toolkit_uses_gtk%': '<(toolkit_uses_gtk)',
     'use_skia%': '<(use_skia)',
     'use_x11%': '<(use_x11)',
     'use_gnome_keyring%': '<(use_gnome_keyring)',
     'linux_fpic%': '<(linux_fpic)',
     'enable_flapper_hacks%': '<(enable_flapper_hacks)',
     'chromeos%': '<(chromeos)',
     'touchui%': '<(touchui)',
+    'webui_bookmark_editor%': '<(webui_bookmark_editor)',
     'webui_certificate_viewer%': '<(webui_certificate_viewer)',
     'file_manager_extension%': '<(file_manager_extension)',
     'inside_chromium_build%': '<(inside_chromium_build)',
     'fastbuild%': '<(fastbuild)',
     'python_ver%': '<(python_ver)',
     'armv7%': '<(armv7)',
     'arm_neon%': '<(arm_neon)',
     'sysroot%': '<(sysroot)',
     'disable_sse2%': '<(disable_sse2)',
     'component%': '<(component)',
@@ skipping 334 matching lines @@
       }],
       ['toolkit_views==1', {
         'grit_defines': ['-D', 'toolkit_views'],
       }],
       ['toolkit_uses_pure_views==1', {
         'grit_defines': ['-D', 'toolkit_uses_pure_views'],
       }],
       ['touchui==1', {
         'grit_defines': ['-D', 'touchui'],
       }],
+      ['webui_bookmark_editor==1', {
+        'grit_defines': ['-D', 'webui_bookmark_editor'],
+      }],
       ['webui_certificate_viewer==1', {
         'grit_defines': ['-D', 'webui_certificate_viewer'],
       }],
       ['file_manager_extension==1', {
         'grit_defines': ['-D', 'file_manager_extension'],
       }],
       ['remoting==1', {
         'grit_defines': ['-D', 'remoting'],
       }],
       ['use_titlecase_in_grd_files==1', {
@@ skipping 1266 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }