Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 7572015: Move types that are used as arguments to function definitions in IME extension API. (Closed)

Created:
9 years, 4 months ago by Zachary Kuznia
Modified:
9 years, 4 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Move types that are used as arguments to function definitions in IME extension API. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95774

Patch Set 1 #

Patch Set 2 : Code Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -49 lines) Patch
M chrome/common/extensions/api/extension_api.json View 5 chunks +76 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zachary Kuznia
9 years, 4 months ago (2011-08-04 10:25:59 UTC) #1
Matt Perry
Why? It's nice to share MenuItem. Though I thought the syntax was "$ref": "MenuItem" rather ...
9 years, 4 months ago (2011-08-04 18:03:28 UTC) #2
Zachary Kuznia
Mostly because this didn't seem to work like I expected. It generates errors "Invalid parameter ...
9 years, 4 months ago (2011-08-05 08:00:59 UTC) #3
Matt Perry
9 years, 4 months ago (2011-08-05 18:46:59 UTC) #4
I see. LGTM

Powered by Google App Engine
This is Rietveld 408576698