Issue 7572013: Additional functions to Harmony weak maps API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7572013: Additional functions to Harmony weak maps API. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger

Modified:
9 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Additional functions to Harmony weak maps API. R=rossberg@chromium.org BUG=v8:1565 TEST=mjsunit/harmony/weakmaps Committed: http://code.google.com/p/v8/source/detail?r=8825

Patch Set 2 : Fix how undefined is used. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -1 line)			Patch
	M	src/weakmap.js	View	1	1 chunk	+24 lines, -1 line	0 comments	Download
	M	test/mjsunit/harmony/weakmaps.js	View		3 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM http://codereview.chromium.org/7572013/diff/1/src/weakmap.js File src/weakmap.js (right): http://codereview.chromium.org/7572013/diff/1/src/weakmap.js#newcode75 src/weakmap.js:75: %WeakMapSet(this, key, global.undefined); Better use `void 0' to ...

9 years, 4 months ago (2011-08-04 11:05:09 UTC) #2

Michael Starzinger

9 years, 4 months ago (2011-08-04 11:12:41 UTC) #3

Uploaded new patch set.

http://codereview.chromium.org/7572013/diff/1/src/weakmap.js
File src/weakmap.js (right):

http://codereview.chromium.org/7572013/diff/1/src/weakmap.js#newcode75
src/weakmap.js:75: %WeakMapSet(this, key, global.undefined);
On 2011/08/04 11:05:09, rossberg wrote:
> Better use `void 0' to get undefined.

Done.

Expand Messages | Collapse Messages

Issue 7572013: Additional functions to Harmony weak maps API. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix how undefined is used. #

Messages