Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 7572003: Update Google Calendar Checker extension. (Closed)

Created:
9 years, 4 months ago by kurrik.chromium
Modified:
9 years, 4 months ago
Reviewers:
Mike West, anujb
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Update Google Calendar Checker extension. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96017

Patch Set 1 #

Patch Set 2 : Updating manifest and background.js files #

Patch Set 3 : Reupload before submit #

Patch Set 4 : Updating before commit #

Patch Set 5 : Rebuilt docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -53 lines) Patch
chrome/common/extensions/docs/examples/extensions/calendar.zip View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/ar/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/bg/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/ca/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/cs/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/da/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/de/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/el/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/_locales/en/messages.json View 1 chunk +1 line, -38 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/en_GB/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/es/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/es_419/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/et/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/fi/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/fil/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/fr/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/he/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/hi/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/hr/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/hu/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/id/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/it/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/ja/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/ko/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/lt/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/lv/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/nb/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/nl/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/pl/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/pt_BR/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/pt_PT/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/ro/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/ru/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/sk/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/sl/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/sr/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/sv/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/th/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/tr/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/uk/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/vi/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/zh_CN/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/calendar/_locales/zh_TW/messages.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/javascript/background.js View 1 2 3 8 chunks +26 lines, -14 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/calendar/manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 2 3 4 1 chunk +82 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 4 2 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kurrik.chromium
Hi Anuj, Wanted to close this request. I've decided it's easier to commit the samples ...
9 years, 4 months ago (2011-08-03 18:49:20 UTC) #1
anujb
Thanks Arne. The CL looks good to me. I would like you to update background.js ...
9 years, 4 months ago (2011-08-04 08:44:54 UTC) #2
Mike West
9 years, 4 months ago (2011-08-09 17:52:09 UTC) #3
On 2011/08/04 08:44:54, anujb wrote:
> Thanks Arne. The CL looks good to me. I would like you to update background.js
> which contains minor bug fixes that went later on. I am sending it in the
mail.

Formalizing anujb@'s LGTM with the magic words that let Arne land the patch and
get on with his life. :)

Powered by Google App Engine
This is Rietveld 408576698