Issue 7569030: Try to fix BookmarkEditorControllerNoNodeTest.NoNodeNoTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7569030: Try to fix BookmarkEditorControllerNoNodeTest.NoNodeNoTree (Closed)

Created:
9 years, 4 months ago by Nico

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai, mrossetti

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Try to fix BookmarkEditorControllerNoNodeTest.NoNodeNoTree displayName is set to initialName in -[BookmarkEditorBaseController awakeFromNib], and initialName is [@"" retain]. This seems to return a new object with clang but the same object with gcc. Not relying on internalized strings seems cleaner in general. BUG=none TEST=tree goes green TBR=mrossetti Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95753

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM BLTN

Expand Messages | Collapse Messages