Issue 7569022: Make TabContentsView implementations use OVERRIDE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7569022: Make TabContentsView implementations use OVERRIDE (Closed)

Created:
9 years, 4 months ago by Evan Martin

Modified:
9 years, 4 months ago

Reviewers:
tony

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make TabContentsView implementations use OVERRIDE I want to change a function prototype and I'm scared of getting it wrong in a subclass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95702

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -40 lines)			Patch
M	chrome/browser/tab_contents/tab_contents_view_gtk.h	View	1 chunk	+20 lines, -20 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.h	View	1 chunk	+20 lines, -20 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_view_views.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM