Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 7569021: top/bottom shadow should now go away in gaia signin screen. (Closed)

Created:
9 years, 4 months ago by achuithb
Modified:
9 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

top/bottom shadow should now go away in gaia signin screen. Put common code in hr.shadow class. BUG=chromium-os:18807 TEST=Top and bottom lines should not be present in gaia signin screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95725

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
9 years, 4 months ago (2011-08-05 23:26:01 UTC) #1
xiyuan
LGTM Think you need a bug if you want to merge this into 835 branch. ...
9 years, 4 months ago (2011-08-05 23:40:17 UTC) #2
achuithb
http://codereview.chromium.org/7569021/diff/2001/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/7569021/diff/2001/chrome/browser/resources/chromeos/login/oobe.css#newcode39 chrome/browser/resources/chromeos/login/oobe.css:39: hr.shadow { I should've written an explanation. The transition ...
9 years, 4 months ago (2011-08-05 23:43:15 UTC) #3
xiyuan
http://codereview.chromium.org/7569021/diff/2001/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/7569021/diff/2001/chrome/browser/resources/chromeos/login/oobe.css#newcode476 chrome/browser/resources/chromeos/login/oobe.css:476: -webkit-transition: all .8s ease; On 2011/08/05 23:43:15, achuith.bhandarkar wrote: ...
9 years, 4 months ago (2011-08-05 23:47:03 UTC) #4
commit-bot: I haz the power
9 years, 4 months ago (2011-08-06 03:24:17 UTC) #5
Change committed as 95725

Powered by Google App Engine
This is Rietveld 408576698