Add utility functions to Message classes.

Add utility functions to Message classes.

The new functions will be used to implement other classes
that will be added in a separate patch.

BUG=90036
TEST=run unit tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96231

[stevenjb, 2011-08-09 18:30:28]

http://codereview.chromium.org/7569020/diff/3001/dbus/message.cc
File dbus/message.cc (right):

http://codereview.chromium.org/7569020/diff/3001/dbus/message.cc#newcode183
dbus/message.cc:183: headers += "destination: " + destination + "\n";
nit: We could simplify this code by creating a local function, e.g. 
AppendStringHeader(headers, "destination", GetDestination()) 
...
AppendUIn32Header(headers, "serial", GetReplySerial())

http://codereview.chromium.org/7569020/diff/3001/dbus/message.cc#newcode320
dbus/message.cc:320: interface = "";
nit: might be slightly more readable as:
std::string interface_string(interface ? interface : "");
since MethodCall() takes string& args.

http://codereview.chromium.org/7569020/diff/3001/dbus/message.h
File dbus/message.h (right):

http://codereview.chromium.org/7569020/diff/3001/dbus/message.h#newcode97
dbus/message.h:97: // Gets the serial and reply serial numbers. Returns 0 f not
set.
s/f/if

[satorux1, 2011-08-09 20:39:08]

http://codereview.chromium.org/7569020/diff/3001/dbus/message.cc
File dbus/message.cc (right):

http://codereview.chromium.org/7569020/diff/3001/dbus/message.cc#newcode183
dbus/message.cc:183: headers += "destination: " + destination + "\n";
On 2011/08/09 18:30:41, Steven Bennetts wrote:
> nit: We could simplify this code by creating a local function, e.g. 
> AppendStringHeader(headers, "destination", GetDestination()) 
> ...
> AppendUIn32Header(headers, "serial", GetReplySerial())

Good idea. Done.

http://codereview.chromium.org/7569020/diff/3001/dbus/message.cc#newcode320
dbus/message.cc:320: interface = "";
On 2011/08/09 18:30:41, Steven Bennetts wrote:
> nit: might be slightly more readable as:
> std::string interface_string(interface ? interface : "");
> since MethodCall() takes string& args.

Good idea. Done.

http://codereview.chromium.org/7569020/diff/3001/dbus/message.h
File dbus/message.h (right):

http://codereview.chromium.org/7569020/diff/3001/dbus/message.h#newcode97
dbus/message.h:97: // Gets the serial and reply serial numbers. Returns 0 f not
set.
On 2011/08/09 18:30:41, Steven Bennetts wrote:
> s/f/if

Done.

[stevenjb, 2011-08-09 20:45:15]

LGTM

[commit-bot: I haz the power, 2011-08-10 22:34:06]

Change committed as 96231