Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2606)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 7569004: Improve the accessibility of some of the oobe html pages. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
===================================================================
--- chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (revision 95578)
+++ chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (working copy)
@@ -98,6 +98,10 @@
UserImageScreen.addUserImage = function(src, clickHandler) {
var imageElement = document.createElement('img');
imageElement.src = src;
+ imageElement.setAttribute('role', 'option');
+ imageElement.setAttribute('tabindex', '-1');
+ imageElement.setAttribute(
+ 'aria-label', src.replace(/(.*\/|\.png)/g, '').replace(/_/g, ' '));
imageElement.addEventListener('click',
clickHandler,
false);
@@ -115,6 +119,20 @@
imageUrl,
UserImageScreen.handleImageClick);
}
+
+ var userImageScreen = $('user-image');
+ var userImageList = $('user-image-list');
+ userImageList.addEventListener('keydown', function(e) {
+ var prevIndex = userImageScreen.selectedUserImage_;
+ var len = userImageList.children.length;
+ if (e.keyCode == 39 || e.keyCode == 40) { // right or down
+ if (prevIndex < len - 1)
+ UserImageScreen.selectUserImage(prevIndex + 1);
+ } else if (e.keyCode == 37 || e.keyCode == 38) { // left or up
+ if (prevIndex > 0)
+ UserImageScreen.selectUserImage(prevIndex - 1);
+ }
+ });
};
/**
@@ -127,10 +145,13 @@
var prevIndex = userImageScreen.selectedUserImage_;
if (prevIndex != -1) {
userImageList.children[prevIndex].classList.remove('user-image-selected');
+ userImageList.children[prevIndex].setAttribute('tabIndex', '-1');
}
if (index != -1) {
var selectedImage = userImageList.children[index];
selectedImage.classList.add('user-image-selected');
+ selectedImage.setAttribute('tabIndex', '0');
+ selectedImage.focus();
$('user-image-preview').src = selectedImage.src;
}
userImageScreen.selectedUserImage_ = index;

Powered by Google App Engine
This is Rietveld 408576698