Issue 7569004: Improve the accessibility of some of the oobe html pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7569004: Improve the accessibility of some of the oobe html pages. (Closed)

Created:
9 years, 4 months ago by dmazzoni

Modified:
9 years, 4 months ago

Reviewers:
whywhat, zel

CC:
chromium-reviews, arv (Not doing code reviews), Zachary Kuznia, hashimoto

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Improve the accessibility of some of the oobe html pages. This is just a start. BUG=chromium-os:14807 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95783

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -10 lines)			Patch
M	chrome/browser/resources/chromeos/login/oobe.css	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_network.html	View		1 chunk	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.html	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.js	View		3 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

whywhat

9 years, 4 months ago (2011-08-05 07:23:15 UTC) #2

LGTM

http://codereview.chromium.org/7569004/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/7569004/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe.css:183: outline: none;
nit: sort properties alphabetically, please

Expand Messages | Collapse Messages