Issue 7569001: Fix performance regression due to elements refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7569001: Fix performance regression due to elements refactor (Closed)

Created:
9 years, 4 months ago by danno

Modified:
9 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix performance regression due to elements refactor Consolidate the runtime logic for fetching elements from Objects and JSObjects so that element access in the GetElement cases that are not handled in generated code. R=svenpanne@chromium.org BUG=none TEST=closure.js test faster Committed: http://code.google.com/p/v8/source/detail?r=8815

Patch Set 1 #

Patch Set 2 : merge with latest #

Total comments: 1

Patch Set 3 : review feedback #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -54 lines)			Patch
	M	src/objects.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/objects.cc	View	1 2	2 chunks	+56 lines, -53 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

9 years, 4 months ago (2011-08-03 12:09:45 UTC) #2

LGTM

http://codereview.chromium.org/7569001/diff/3001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7569001/diff/3001/src/objects.cc#newcode611
src/objects.cc:611: // Iterate up the prototype chain until an element is found
of the null
sed 's/of/or/' :-)

Expand Messages | Collapse Messages